Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fallback to current run command on ODD if run diverges from analysis #14821

Merged
merged 9 commits into from
May 1, 2024

Conversation

b-cooper
Copy link
Contributor

@b-cooper b-cooper commented Apr 5, 2024

Overview

In the case of a non-deterministic protocol, the running protocol screen of the on device display app will fall back to showing no command text at all, instead it should fall back to showing the current running command

Closes PLAT-274

Review requests

Run a non-deterministic protocol, the ODD should display the current executing command, even after the divergence point.

e.g.

add the following to a python protocol.

if not protocol.is_simulating():
          protocol.comment(message="this should only be shown in the run, not in analysis")

Ensure that runtime only the comment and all following resulting commands are still shown in the Running Protocol screen of the on device display.

Risk assessment

low

b-cooper added 4 commits April 5, 2024 16:52
… analysis

In the case of a non-deterministic protocol, the running protocol screen of the on device display
app will fall back to showing no command text at all, instead it should fall back to showing the
current running command

Closes PLAT-274
@b-cooper b-cooper marked this pull request as ready for review May 1, 2024 18:52
@b-cooper b-cooper requested review from a team as code owners May 1, 2024 18:52
@b-cooper b-cooper requested review from TamarZanzouri and removed request for a team May 1, 2024 18:52
@b-cooper b-cooper requested review from shlokamin and brenthagen and removed request for TamarZanzouri May 1, 2024 19:07
Copy link
Contributor

@brenthagen brenthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@b-cooper b-cooper merged commit 657d259 into edge May 1, 2024
20 checks passed
@b-cooper b-cooper deleted the app_fix-non-deterministic-odd-run-command branch May 1, 2024 22:28
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
… analysis (#14821)

In the case of a non-deterministic protocol, the running protocol screen
of the on device display app will fall back to showing no command text
at all, instead it should fall back to showing the current running
command

Closes PLAT-274
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants