Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(components): update parameter table stories #14815

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Apr 5, 2024

Overview

I noticed that parameter table is using Story type during the code review.
remove Story type and use StoryObj

close AUTH-289

Test Plan

Changelog

  • switch the type from Story to StoryObj
  • add padding to the table
  • change Chip's default type since basic will be replaced with Tag component

Review requests

Risk assessment

low

remove Story type and use StoryObj

close AUTH-289
@koji koji requested review from ncdiehl11 and jerader April 5, 2024 15:32
@koji koji marked this pull request as ready for review April 5, 2024 15:32
@koji koji requested a review from a team as a code owner April 5, 2024 15:32
@koji koji removed the request for review from a team April 5, 2024 15:32
@koji koji added the authorship label Apr 5, 2024
runTimeParameters: runTimeParameters,

const meta: Meta<typeof ParametersTable> = {
title: 'Library/Molecules/ParametersTable',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating this story!

Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@koji koji merged commit 3385bf1 into edge Apr 8, 2024
46 checks passed
@koji koji deleted the refactor_parametertable-stories branch April 8, 2024 17:00
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
* refactor(components): update parameter table stories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants