Exec 372 hide performance metrics project behind ff #14811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerekMaggio
changed the base branch from
edge
to
EXEC-380-create-performance-metrics-project
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #14811 +/- ##
=======================================
Coverage 67.24% 67.24%
=======================================
Files 2495 2495
Lines 71254 71254
Branches 8937 8937
=======================================
Hits 47918 47918
Misses 21235 21235
Partials 2101 2101
Flags with carried forward coverage won't be shown. Click here to find out more.
|
DerekMaggio
force-pushed
the
EXEC-372-hide-performance-metrics-project-behind-ff
branch
from
86f6e0d to
1d039b0
Compare
DerekMaggio
changed the base branch from
EXEC-380-create-performance-metrics-project
to
edge
# Overview
When we patch the _read_settings_file function, we are calling to
fixtures that exclude flags that have internal_only set to True. When
you look at the _read_settings_file function there is no filtering out
of flags set to internal_only.
```python
def _read_settings_file(settings_file: "Path") -> SettingsData:
"""
Read the settings file, which is a json object with settings IDs as keys
and boolean values. For each key, look up the `Settings` object with that
key. If the key is one of the old IDs (kebab case), replace it with the
new ID and rewrite the settings file
:param settings_file: the path to the settings file
:return: a dict with all new settings IDs as the keys, and boolean values
(the values stored in the settings file, or `False` if the key was not
found). Along with the version.
"""
# Read settings from persistent file
data = _read_json_file(settings_file)
settings, version = _migrate(data)
settings = _ensure(settings)
if data.get("_version") != version:
_write_settings_file(settings, version, settings_file)
return SettingsData(settings_map=settings, version=version)
```
Therefore, the patches for the OT-2 and Flex should be calling the
fixtures that do not exclude the internal_only flag.
formatting chore: formatting and configs chore: remove comment add more cleaning fix data
DerekMaggio
force-pushed
the
EXEC-372-hide-performance-metrics-project-behind-ff
branch
from
5f583b1 to
589a8b8
Compare
DerekMaggio
deleted the
EXEC-372-hide-performance-metrics-project-behind-ff
branch
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
# Overview Add feature flag for Performance Metrics project. Closes https://opentrons.atlassian.net/browse/EXEC-372 # Changelog - Add enablePerformanceMetrics feature flag in advanced settings - Add migration function - Update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add feature flag for Performance Metrics project.
Closes https://opentrons.atlassian.net/browse/EXEC-372
Changelog