-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hardware-testing): liquid sense testing script #14807
Merged
Merged
Changes from 53 commits
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
01493ef
first pass at skeletoning out the liquid sense script
ryanthecoder 86c44e8
stub out some more arguments
ryanthecoder 72d2c11
add unit test calls for liquid sense script
ryanthecoder 0666978
fix all the things the testing showed were broken
ryanthecoder d80402c
format
ryanthecoder 0efdd1a
start stubbing out report
ryanthecoder 025b0d8
remove preheat
ryanthecoder 37d7043
finish out stubbing report
ryanthecoder ff763b6
add fake probing
ryanthecoder 5649811
flesh out the stat calclation
ryanthecoder b5a4262
add tip handleing
ryanthecoder 27143c7
hook up actually using data_file for lps
ryanthecoder 4624226
add plunger pos to trial data
ryanthecoder 76fe6ad
fixup some things around datafiles
ryanthecoder 0989421
format/fixes
ryanthecoder 7769cba
format lint
ryanthecoder 5d3fced
minor first pass fixes
ryanthecoder e7114a6
missed one
ryanthecoder a12bb33
imports
ryanthecoder cea129f
change liquid_probe to support synced reading
caila-marashaj 3da58d4
upgrades from running
ryanthecoder 1a28809
make stop condition sync line
caila-marashaj 365aff9
set head move condition to sync
caila-marashaj 4935a14
changes from IRL testing
ryanthecoder abc9d80
add manual probe to calibrate liquid hieght and add dial indicator to…
ryanthecoder 1cafdde
we got a new dial holder so update our labware def
ryanthecoder 4acbbe7
add way to ignore dial
ryanthecoder c5fde75
send a message to dump all the pressure data over can after a move
ryanthecoder 44976ed
format lint
ryanthecoder a5a773a
improve dial reading
ryanthecoder b4942b3
fixes and upgrades from testing
ryanthecoder ece8039
some small formating fixes and added a title line to the trials secti…
ryanthecoder 93cf2e6
improve the way we calibrate tip length variation
ryanthecoder 2c3f63f
add the dial slot to the other liquid sense lpc protocols
ryanthecoder da61494
clean up print outs during script and make simulation pass
ryanthecoder 0ab1d97
upgrade the csv report based on testing feedback
ryanthecoder 9d83f8d
add a post processing to liquid-sense
ryanthecoder 2485663
align up the start z of the of each trial in the final report
ryanthecoder 9daeec6
add a lable colume
ryanthecoder 0757cd7
fixup some post process errors
ryanthecoder 25d92df
remove unneeded print
ryanthecoder b3a82e8
jog after given number of trials
caila-marashaj 78752c1
fix typos
caila-marashaj 73c35ea
make time alignment optional
caila-marashaj 994406f
fixup things from rebase
ryanthecoder 12476be
Revert "format lint"
ryanthecoder 65ff7df
fix upgrades to PE version
ryanthecoder a31e813
add a better traceback for caught errors
ryanthecoder 3d29f44
trials_before_jog needs to be an int, and also do a jog on trial 0
ryanthecoder 805f339
need to return after storing the baseline trial
ryanthecoder 5bfe700
format
ryanthecoder 6fce549
remove some print statements
ryanthecoder a342186
lint tool_sensors.py
ryanthecoder efa16f4
remove uneeded change to ot3_api
ryanthecoder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 changes: 57 additions & 0 deletions
57
hardware-testing/hardware_testing/labware/dial_indicator/1.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
{ | ||
"schemaVersion": 2, | ||
"version": 1, | ||
"namespace": "custom_beta", | ||
"ordering": [["A1"]], | ||
"metadata": { | ||
"displayName": "Mitutoyo Digimatic Indicator", | ||
"displayCategory": "tubeRack", | ||
"displayVolumeUnits": "µL", | ||
"tags": [] | ||
}, | ||
"dimensions": { | ||
"xDimension": 128, | ||
"yDimension": 86, | ||
"zDimension": 136 | ||
}, | ||
"parameters": { | ||
"format": "irregular", | ||
"quirks": [], | ||
"isTiprack": false, | ||
"isMagneticModuleCompatible": false, | ||
"loadName": "dial_indicator" | ||
}, | ||
"wells": { | ||
"A1": { | ||
"depth": 14, | ||
"totalLiquidVolume": 10, | ||
"shape": "circular", | ||
"diameter": 4, | ||
"x": 60.8, | ||
"y": 41.5, | ||
"z": 135 | ||
} | ||
}, | ||
"brand": { | ||
"brand": "Mitutoyo", | ||
"brandId": ["ID-S"] | ||
}, | ||
"groups": [ | ||
{ | ||
"brand": { | ||
"brand": "Mitutoyo", | ||
"brandId": ["ID-S"] | ||
}, | ||
"metadata": { | ||
"wellBottomShape": "flat", | ||
"displayCategory": "tubeRack" | ||
}, | ||
"wells": ["A1"] | ||
} | ||
], | ||
"cornerOffsetFromSlot": { | ||
"x": 0, | ||
"y": 0, | ||
"z": 0 | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
"""Liquid Sense.""" |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's note this change a little more prominently in the pr description or better yet make it a separate pr please