Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(app, api-client): remove mock RTP datafrom ProtocolDetails #14791

Merged
merged 2 commits into from
Apr 3, 2024
Merged

chore(app, api-client): remove mock RTP datafrom ProtocolDetails #14791

merged 2 commits into from
Apr 3, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Apr 3, 2024 •
edited
Loading

closes AUTH-266

Overview

Remove mock RTP data from ProtocolDetails. Land on parameters tab for RTP-containing protocols.

Test Plan

RTP protocol

  • upload a protocol containing RTPs
  • select protocol card to land on protocol details screen
  • verify that you land on 'parameters' tab and protocol parameters are mapped properly (read only)

non-RTP protocol

  • upload a protocol not containing RTPs
  • select protocol card to land on protocol details screen
  • verify that you land on 'hardware' tab
  • verify that 'parameters' tab renders 'No parameters specified in this protocol'
Screen.Recording.2024-04-03.at.12.49.21.PM.mov

Changelog

  • remove mock data
  • on ProtocolDetails, pull RTPs from mostRecentAnalysis
  • update protocol test fixture to include RTPs

Review requests

authorship devs

Risk assessment

low

@ncdiehl
chore(app, api-client): remove mock RTP datafrom ProtocolDetails
ff844d3 
Remove mock RTP data from ProtocolDetails. Land on parameters tab for RTP-containing protocols.
@ncdiehl11 ncdiehl11 requested review from koji and jerader April 3, 2024 16:52
@ncdiehl11 ncdiehl11 marked this pull request as ready for review April 3, 2024 16:52
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner April 3, 2024 16:52
koji
koji approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
thanks!

jerader
jerader approved these changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove the mock data in useRunTimeParameters as well?

@ncdiehl11 ncdiehl11 merged commit 0f7d1ff into edge Apr 3, 2024
22 checks passed
@ncdiehl11 ncdiehl11 deleted the chore_app-remove-mock-rtps branch April 3, 2024 19:46
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
@ncdiehl11 @Carlos-fernandez
chore(app, api-client): remove mock RTP datafrom ProtocolDetails (#14791
c264cd3 
)

closes AUTH-266
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koji koji koji approved these changes

@jerader jerader jerader approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ncdiehl11 @koji @jerader @ncdiehl