feat(opentrons-ai-client, opentrons-ai-server): add folders for opentrons-ai #14788

koji · 2024-04-03T14:52:14Z

Overview

opentrons-ai-client: frontend
opentrons-ai-server: backend (content will be added later)

js set up commnad works without any errors and when you run make -C opentrons-ai-client dev, the dev server works without any errors and you can access localhost:5173.

close AUTH-202, AUTH-203

Test Plan

run make teardown-js && make setup-js
run make -C opentrons-ai-client dev
react application shows up

Changelog

add opentrons-ai-client and opentrons-ai-server

Review requests

Risk assessment

low

…rons ai opentrons-ai-client: frontend opentrons-ai-server: backend close AUTH-202, AUTH-203

koji · 2024-04-08T22:14:04Z

add eslint config

shlokamin · 2024-04-09T14:39:15Z

opentrons-ai-client/src/App.css

+#root {
+  max-width: 1280px;


we should consider using styled-components like we do in the app for consistency. we can create global styles like this: https://github.com/Opentrons/opentrons/blob/edge/app/src/atoms/GlobalStyle/index.ts

all css files are deleted.

opentrons-ai-client/src/i18n.ts

jerader · 2024-04-09T21:03:01Z

opentrons-ai-client/package.json

+    "@fontsource/dejavu-sans": "5.0.3",
+    "@fontsource/public-sans": "5.0.3",
+    "@opentrons/components": "link:../components",
+    "i18next": "^19.8.3",


good idea to add i18next right off the bat instead of what we did with PD haha

jerader · 2024-04-09T21:05:42Z

opentrons-ai-server/Makefile

@@ -0,0 +1,2 @@
+# opentrons ai server makefile
+# TBD


is this makefile needed?

i guess it is but looks to be causing a lint error right now

Really?
Did you run make lint?

I ran the command and I didn't see any errors.
Could you share the error you saw?

oh my bad, i thought this red icon thing meant there was a lint error 😅

thank you for sharing.
fortunately, that isn't a lint error.

jerader · 2024-04-09T21:07:26Z

opentrons-ai-server/README.md

+# prerequisite: install dependencies as specified in project setup
+make setup
+# launch the dev server
+make -C opentrons-ai-server dev


just double checking that this make -C opentrons-ai-server dev does not work yet right?

not yet.
server will be added, and we will use python for the backend.

opentrons-ai-client/src/assets/react.svg

jerader

nice! I followed the instructions and opened up the opentrons ai react app 🎉 . Great work so far, everything is very organized in my opinion. Just left some comments and questions but nothing too major.

Elyorcv · 2024-04-09T23:03:43Z

opentrons-ai-client/README.md

+- [React][]
+- [Babel][]
+- [Vite][]


Could we add a single sentence for each line to know why they are there?

Actually, the reason is monorepo

Elyorcv · 2024-04-09T23:05:22Z

opentrons-ai-client/README.md

+
+Some important directories:
+
+- `opentrons-ai-server` — Opentrons AI application's server


Nitpick: Could we provide hyperlink here so that when we click it we go directly there.

Elyorcv · 2024-04-09T23:12:37Z

opentrons-ai-client/README.md

+
+## Copy management
+
+We use [i18next](https://www.i18next.com) for copy management and internationalization.


What does internationalisation mean here?

can be translated into other languages and that is the reason why we use i18next.

you mean English to Japan for example?

yeah that is one example.
I think we can gat help from Ed to make readme better before the externa beta testing.

i18next will work like this when we add simple ui for language change and json files for languages.

Elyorcv

LGTM. Could you provide a diagram showing how all the tools and libraries are connected? I want to see how each one is used. If that's not possible, no worries.

opentrons-ai-client/src/assets/localization/en/protocol_generator.json

Elyorcv · 2024-04-09T23:24:43Z

opentrons-ai-client/src/assets/localization/en/protocol_generator.json

+  "tipracks_and_labware": "Tip racks and labware: Use names from the Opentrons Labware Library.",
+  "type_your_prompt": "Type your prompt...",
+  "well_allocations": "Well allocations: Describe where liquids should go in labware.",
+  "what_if_you": "What if you don’t provide all of those pieces of information?",


Since OpenAI cannot follow instruction consistently, this may not happen all the time. So I am happy to remove this line.

Why everything line by line, why dont we do something like triplet quote in python?
''' '''

This is json file and we use eslint.

koji · 2024-04-10T04:04:49Z

LGTM. Could you provide a diagram showing how all the tools and libraries are connected? I want to see how each one is used. If that's not possible, no worries.

Yup, I will create a doc for this for engineers.

…tor.json Co-authored-by: Elyor Kodirov <[email protected]>

…rons-ai (#14788) * feat(opentrons-ai-client, opentrons-ai-server): add folders for opentrons-ai

feat(opentrons-ai-client,opentrons-ai-serever): add folders for opent…

a622d69

…rons ai opentrons-ai-client: frontend opentrons-ai-server: backend close AUTH-202, AUTH-203

koji requested review from a team, sanni-t, Elyorcv and jbleon95 and removed request for a team, sanni-t, Elyorcv and jbleon95 April 3, 2024 14:52

koji added 3 commits April 3, 2024 10:56

add Makefile

ec8339f

add initial files

aa3d771

add initial text files

4b56c4f

koji added the authorship label Apr 4, 2024

add test utils

9cb56da

koji requested review from y3rsh, ncdiehl11 and jerader April 8, 2024 21:56

koji marked this pull request as ready for review April 8, 2024 21:59

koji requested review from a team as code owners April 8, 2024 21:59

koji removed request for a team April 8, 2024 21:59

koji marked this pull request as draft April 8, 2024 22:13

shlokamin reviewed Apr 9, 2024

View reviewed changes

opentrons-ai-client/src/i18n.ts Outdated Show resolved Hide resolved

koji added 4 commits April 9, 2024 14:31

remove unnecessary css files

5a0864e

format files

374f9ae

fix linting errors

ec56812

fix lint errors

46973aa

koji requested a review from shlokamin April 9, 2024 19:42

koji marked this pull request as ready for review April 9, 2024 19:42

koji requested a review from Elyorcv April 9, 2024 20:42

jerader reviewed Apr 9, 2024

View reviewed changes

opentrons-ai-client/src/assets/react.svg Outdated Show resolved Hide resolved

jerader approved these changes Apr 9, 2024

View reviewed changes

remove svg

a2539bf

Elyorcv reviewed Apr 9, 2024

View reviewed changes

koji and others added 2 commits April 10, 2024 10:50

Update opentrons-ai-client/src/assets/localization/en/protocol_genera…

620cdae

…tor.json Co-authored-by: Elyor Kodirov <[email protected]>

remove µL

d074bdc

koji merged commit e423319 into edge Apr 10, 2024
13 checks passed

koji deleted the feat_add-opentrons-ai branch April 10, 2024 16:43

Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024

feat(opentrons-ai-client, opentrons-ai-server): add folders for opent…

edd7318

…rons-ai (#14788) * feat(opentrons-ai-client, opentrons-ai-server): add folders for opentrons-ai

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(opentrons-ai-client, opentrons-ai-server): add folders for opentrons-ai #14788

feat(opentrons-ai-client, opentrons-ai-server): add folders for opentrons-ai #14788

koji commented Apr 3, 2024 •

edited

Loading

koji commented Apr 8, 2024

shlokamin Apr 9, 2024

koji Apr 9, 2024

jerader Apr 9, 2024

jerader Apr 9, 2024

jerader Apr 9, 2024

koji Apr 9, 2024

koji Apr 9, 2024

jerader Apr 9, 2024

koji Apr 9, 2024

jerader Apr 9, 2024

koji Apr 9, 2024

jerader left a comment

Elyorcv Apr 9, 2024

koji Apr 9, 2024

Elyorcv Apr 9, 2024

Elyorcv Apr 9, 2024

koji Apr 9, 2024

Elyorcv Apr 9, 2024

koji Apr 10, 2024

koji Apr 10, 2024

Elyorcv left a comment

Elyorcv Apr 9, 2024

Elyorcv Apr 9, 2024

koji Apr 10, 2024

koji commented Apr 10, 2024


		Some important directories:

		- `opentrons-ai-server` — Opentrons AI application's server


		## Copy management

		We use [i18next](https://www.i18next.com) for copy management and internationalization.

feat(opentrons-ai-client, opentrons-ai-server): add folders for opentrons-ai #14788

feat(opentrons-ai-client, opentrons-ai-server): add folders for opentrons-ai #14788

Conversation

koji commented Apr 3, 2024 • edited Loading

Overview

Test Plan

Changelog

Review requests

Risk assessment

koji commented Apr 8, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jerader left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Elyorcv left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

koji commented Apr 10, 2024

koji commented Apr 3, 2024 •

edited

Loading