fix(app,shared-data): change type name from boolean to bool #14778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change type name from `boolean` to `bool` because fe uses boolean but actually be returns `bool`. fix AUTH-262
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #14778 +/- ##
=======================================
Coverage 67.19% 67.19%
=======================================
Files 2495 2495
Lines 71388 71387 -1
Branches 8984 8983 -1
=======================================
Hits 47972 47972
Misses 21301 21301
+ Partials 2115 2114 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
thank you for your super quick review! |
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
* fix(app,shared-data): change type name from boolean to bool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
change type name from
booleantoboolbecause FE uses boolean but actually BE returnsbool.fix AUTH-262
Test Plan
Changelog
boolean->boolin components that are related to RTPReview requests
Risk assessment
low