Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): add support for toggling boolean RTPs and restoring defaults #14770

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Apr 1, 2024

closes AUTH-117

Overview

This PR adds functionality to restoring default values for all runtime parameter types.

Test Plan

Screen.Recording.2024-04-01.at.2.47.04.PM.mov

Changelog

Review requests

authorship devs

Risk assessment

low

ncdiehl added 2 commits April 1, 2024 15:34
This PR provides toggling functionality to boolean type RTPs on the ODD. It also adds functionality
to restoring default values for all runtime paramter types.
@ncdiehl11 ncdiehl11 marked this pull request as ready for review April 1, 2024 20:55
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner April 1, 2024 20:55
@ncdiehl11 ncdiehl11 requested review from jerader and removed request for a team April 1, 2024 20:55
@ncdiehl11 ncdiehl11 requested a review from jerader April 2, 2024 15:43
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ncdiehl11 ncdiehl11 merged commit 2dbb1d9 into edge Apr 2, 2024
20 checks passed
@ncdiehl11 ncdiehl11 deleted the feat_app-odd-rtp-booleans branch April 2, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants