Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer, step-generation): x/Y tip positioning for asp, disp, mix #14758

Merged
merged 8 commits into from
Apr 3, 2024

address comments

8a90c53
Select commit
Loading
Failed to load commit list.
Merged

feat(protocol-designer, step-generation): x/Y tip positioning for asp, disp, mix #14758

address comments
8a90c53
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 2, 2024 in 0s

67.24% (+0.06%) compared to 0fbb4c7

View this Pull Request on Codecov

67.24% (+0.06%) compared to 0fbb4c7

Details

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 67.24%. Comparing base (0fbb4c7) to head (8a90c53).
Report is 12 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #14758      +/-   ##
==========================================
+ Coverage   67.17%   67.24%   +0.06%     
==========================================
  Files        2495     2495              
  Lines       71483    71352     -131     
  Branches     9020     8971      -49     
==========================================
- Hits        48020    47980      -40     
+ Misses      21341    21256      -85     
+ Partials     2122     2116       -6     
Files Coverage Δ
...gner/src/components/BatchEditForm/BatchEditMix.tsx 0.00% <ø> (ø)
...c/components/BatchEditForm/BatchEditMoveLiquid.tsx 0.00% <ø> (ø)
...src/components/StepEditForm/fields/DelayFields.tsx 20.00% <ø> (ø)
...nts/StepEditForm/fields/TipPositionField/index.tsx 5.00% <ø> (+1.66%) ⬆️
...ents/StepEditForm/fields/TipPositionField/utils.ts 33.33% <ø> (ø)
...gner/src/components/StepEditForm/forms/MixForm.tsx 0.00% <ø> (ø)
...EditForm/forms/MoveLiquidForm/SourceDestFields.tsx 0.00% <ø> (ø)
protocol-designer/src/form-types.ts 42.85% <ø> (ø)
...r/src/steplist/formLevel/getDefaultsForStepType.ts 81.81% <ø> (ø)
...steplist/formLevel/stepFormToArgs/mixFormToArgs.ts 68.42% <ø> (ø)
... and 11 more

... and 5 files with indirect coverage changes