Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): add tooltips to ChooseRobotToRunProtocolSlideout RTPs, update types #14740

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Mar 27, 2024

closes AUTH-100

Overview

According to designs, number type RTPs should display their respective numerical ranges as InputField captions. The optional RTP description should be displayed in a tooltip when an information icon is hovered next to the RTP title. As part of the scope of this change, I also refactor the runtime parameter types so that the type of the RTP (numerical vs choice vs boolean) will narrow to the appropriate properties of that specific RTP when mapping.

Test Plan

  • Select any protocol from Desktop (mock data is still used for now)
  • Select Start setup
  • Choose any robot and select Continue to parameters
  • Observe style of numerical RTPs with hoverable information icon
  • Select Change robot
  • Verify that slideout moves back to robot select
Screenshot 2024-03-27 at 9 39 21 AM

Changelog

Risk assessment

low

According to designs, number type RTPs should display their respective numerical ranges as
InputField captions. The optional RTP description should be displayed in a tooltip when an
information icon is hovered next to the RTP title. As part of the scope of this change, I also
refactor the runtime parameter types so that the type of the RTP (numerical vs choice vs boolean)
will narrow to the appropriate properties of that specific RTP when mapping.
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.20%. Comparing base (f583aea) to head (d5f9c43).
Report is 5 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #14740   +/-   ##
=======================================
  Coverage   67.20%   67.20%           
=======================================
  Files        2495     2495           
  Lines       71549    71549           
  Branches     9022     9022           
=======================================
  Hits        48085    48085           
  Misses      21342    21342           
  Partials     2122     2122           
Flag Coverage Δ
shared-data 75.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
app/src/atoms/InputField/index.tsx 89.47% <ø> (ø)
app/src/organisms/ChooseRobotSlideout/index.tsx 85.71% <ø> (ø)
...ganisms/ChooseRobotToRunProtocolSlideout/index.tsx 65.85% <ø> (ø)

@ncdiehl11 ncdiehl11 marked this pull request as ready for review March 27, 2024 15:38
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner March 27, 2024 15:38
@ncdiehl11 ncdiehl11 requested review from jerader and koji and removed request for a team March 27, 2024 15:38
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ui looks good! i have a question about the type changes you made

@ncdiehl11 ncdiehl11 requested a review from jerader March 27, 2024 20:39
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the type change. I guess with that change we can clean up a few areas in the code in Parameters and ParametersTable

@ncdiehl11 ncdiehl11 changed the title feat(app): add tooltips to ChooseRobotToRunProtocolSlideout RTPs feat(app): add tooltips to ChooseRobotToRunProtocolSlideout RTPs, update types Mar 27, 2024
@ncdiehl11 ncdiehl11 merged commit b82b030 into edge Mar 27, 2024
40 checks passed
@ncdiehl11 ncdiehl11 deleted the feat_rtp-slideout-tooltip branch March 27, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants