-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app): add tooltips to ChooseRobotToRunProtocolSlideout RTPs, update types #14740
Conversation
According to designs, number type RTPs should display their respective numerical ranges as InputField captions. The optional RTP description should be displayed in a tooltip when an information icon is hovered next to the RTP title. As part of the scope of this change, I also refactor the runtime parameter types so that the type of the RTP (numerical vs choice vs boolean) will narrow to the appropriate properties of that specific RTP when mapping.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #14740 +/- ##
=======================================
Coverage 67.20% 67.20%
=======================================
Files 2495 2495
Lines 71549 71549
Branches 9022 9022
=======================================
Hits 48085 48085
Misses 21342 21342
Partials 2122 2122
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ui looks good! i have a question about the type changes you made
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for the type change. I guess with that change we can clean up a few areas in the code in Parameters
and ParametersTable
closes AUTH-100
Overview
According to designs, number type RTPs should display their respective numerical ranges as InputField captions. The optional RTP description should be displayed in a tooltip when an information icon is hovered next to the RTP title. As part of the scope of this change, I also refactor the runtime parameter types so that the type of the RTP (numerical vs choice vs boolean) will narrow to the appropriate properties of that specific RTP when mapping.
Test Plan
Start setup
Continue to parameters
Change robot
Changelog
Risk assessment
low