Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): update chip component style and Storybook #14739

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Mar 26, 2024

Overview

Mel's request for Chip ODD component
update small chip padding 4px 10px to 4px 8px and Storybook iconName list(only display 3 icons).

update storybook to align with version 7 way.
https://storybook.js.org/blog/improved-type-safety-in-storybook-7/

close AUTH-241

Test Plan

Changelog

Review requests

Risk assessment

low

update small chip padding 4px 10px to 4px 8px  and storybook iconName list

close AUTH-241
@koji koji requested review from ncdiehl11 and jerader March 26, 2024 22:37
@koji koji marked this pull request as ready for review March 26, 2024 22:37
@koji koji requested a review from a team as a code owner March 26, 2024 22:37
@koji koji removed the request for review from a team March 27, 2024 01:22
@koji koji requested a review from a team March 27, 2024 04:29
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@koji koji merged commit 2353759 into edge Mar 28, 2024
20 checks passed
@koji koji deleted the fix_update-chip-component-style-and-storybook branch March 28, 2024 13:53
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
* fix(app): update chip component style and Storybook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants