Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(shared-data): add filter tipracks to pipette defaultTipracks #14737

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Mar 26, 2024

closes AUTH-232

Overview

This PR adds the filter tiprack loadnames to the default tipracks list in the Flex pipette definitions. This info is needed for PD to accurately display the selectable tipracks for the given pipette.

Additionally i added the info to defaultTipOverlapDictionary which i am not sure is necessary or not, but just followed the pattern from the gen2 and gen1 pipette definitions

Test Plan

Review the definitions and make sure it looks good.

PD correctly shows the pipettes!

Screenshot 2024-03-26 at 17 00 36

Changelog

  • add the filter tipracks to the pipette flex definitions. i added the info to all versions and default/low volume liquid
  • fix the unit test for the util that returns the data

Review requests

see test plan

Risk assessment

low

@jerader jerader requested review from a team as code owners March 26, 2024 21:02
@jerader jerader requested review from brenthagen, sfoster1, sanni-t, Laura-Danielle and a team and removed request for a team and brenthagen March 26, 2024 21:02
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.20%. Comparing base (1b28bab) to head (4ed9606).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #14737   +/-   ##
=======================================
  Coverage   67.20%   67.20%           
=======================================
  Files        2495     2495           
  Lines       71549    71549           
  Branches     9022     9022           
=======================================
  Hits        48085    48085           
  Misses      21342    21342           
  Partials     2122     2122           
Flag Coverage Δ
shared-data 75.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sfoster1 sfoster1 requested a review from andySigler March 26, 2024 21:07
@sfoster1
Copy link
Member

I think @andySigler should look at this but it seeeeems fine?

@jerader jerader requested a review from a team as a code owner March 26, 2024 21:08
@jerader jerader removed the request for review from a team March 26, 2024 21:56
Copy link
Contributor

@andySigler andySigler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I took a scan through the flex pipette definitions and I don't see any instances of a filtered tip being assigned a tip-overlap other than 10.5 the default, which would mean that this PR has no change in behavior so lgtm

@jerader jerader merged commit 8653b07 into edge Mar 27, 2024
40 checks passed
@jerader jerader deleted the sd_add-default-pipettes branch March 27, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants