Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "refactor(modules): return has update for unexpected module fw filename" #14731

Merged

Conversation

caila-marashaj
Copy link
Contributor

Reverts #14712

Testing on newest edge, I don't think the code after the try-catch is getting executed, and not all modules are showing up.

@caila-marashaj caila-marashaj requested a review from a team as a code owner March 25, 2024 21:38
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.18%. Comparing base (3094f5e) to head (82e1ac0).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #14731   +/-   ##
=======================================
  Coverage   67.18%   67.18%           
=======================================
  Files        2495     2495           
  Lines       71651    71651           
  Branches     9075     9075           
=======================================
  Hits        48140    48140           
  Misses      21367    21367           
  Partials     2144     2144           
Flag Coverage Δ
g-code-testing 92.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../src/opentrons/hardware_control/modules/mod_abc.py 81.25% <ø> (ø)

@caila-marashaj caila-marashaj merged commit 29414e2 into edge Mar 25, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants