Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): sort robot lists alphabetically #14722

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Mar 25, 2024

Closes EXEC-350

Overview

Back during a standup in January, appui agreed that there is no current logic when presenting lists of robots on the Devices tab, sending protocols slideouts, etc. Let's sort robots alphabetically. Doing this via selectors is best because:

  1. Selectors are memoized.
  2. Sorting already filtered lists of robots means we aren't computing this often.
  3. Doing this on every slideout, page, etc. doesn't make much sense, since when we use these selectors, we are using them to display lists of robots.
Screenshot 2024-03-25 at 9 51 27 AM Screenshot 2024-03-25 at 9 51 12 AM

Test Plan

  • Open the app. Observe robots are sorted on the Devices page and robot slideouts.

Changelog

  • Robots are sorted alphabetically on the Devices page and various slideouts.

Risk assessment

low

There is no current logic when presenting lists of robots on the Devices tab, sending protocols
slideouts, etc. Sort robots alphabetically.
@mjhuff mjhuff requested review from a team March 25, 2024 14:03
@mjhuff mjhuff requested a review from a team as a code owner March 25, 2024 14:03
@mjhuff mjhuff requested review from TamarZanzouri and removed request for a team and TamarZanzouri March 25, 2024 14:03
Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment but it is optional.
the changes look good to me.

@mjhuff mjhuff merged commit ede85ef into edge Mar 25, 2024
20 checks passed
@mjhuff mjhuff deleted the app_sort-robots-alphabetically branch March 25, 2024 14:47
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
Closes EXEC-350

There is no current logic when presenting lists of robots on the Devices tab, sending protocols slideouts, etc. Sort robots alphabetically.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants