feat(app): add small size to Chip component for ODD #14717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add small size to Chip component for ODD AUTH-233
jerader
reviewed
Mar 25, 2024
app/src/atoms/Chip/index.tsx
Outdated
| size="1.5rem" | ||
| data-testid="RenderResult_icon" | ||
| size={chipSize === 'medium' ? '1.5rem' : '1.25rem'} | ||
| data-testid={`RenderResult_icon_${chipSize}`} |
There was a problem hiding this comment.
do we use this data-testid for anything like testing or something? if no, then i think we can remove it
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
* feat(app): add small size to Chip component for ODD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
add small size to Chip component for ODD
also update view-only parameters screen's chip prop
design
https://www.figma.com/file/1ot18My22DALIcjdLl5LJh/Helix-Design-System?node-id=2771%3A31729&mode=dev
Chip for Desktop (unification) will be implemented in a following PR. (when this pr is merged into edge)
close AUTH-233
Test Plan
Changelog
Review requests
Risk assessment
low