Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer, step-generation, shared-data): migrate to using pipette v2 schema #14713

Merged
merged 10 commits into from
Mar 26, 2024

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Mar 21, 2024

closes AUTH-52, AUTH-231

Overview

Migrate from using getPipetteNameSpecs to getPipetteV2Specs in PD. This change is necessary both for pipette collision warnings and so flow rates are accurate/reflect the api

There are a few followup action items:

  1. add the filtered tips to the default tips array in the pipette definitions https://opentrons.atlassian.net/browse/AUTH-232
  2. @sanni-t to investigate why there are no mins and maxs for the flowrates in the v2 schema definitions - this information is needed for PD to accurately have a range defining custom flow rates.
  3. determin if the util should return the latest version or not see https://opentrons.atlassian.net/browse/AUTH-243

Test Plan

Smoke test PD to make sure it works as expected. In particular, test these areas:

  1. the create file wizard
  2. adding a transfer and mix step
  3. edit the transfer/mix step's advance settings by changing the flow rates

Changelog

  • migrate all instances of getPipetteNameSpecs to getPipetteV2Specs
  • create util for returning the flow rates
  • fix tests

Review requests

see test plan

Risk assessment

low

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.35%. Comparing base (574f793) to head (e26e5b2).
Report is 71 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #14713      +/-   ##
==========================================
+ Coverage   67.33%   67.35%   +0.02%     
==========================================
  Files        2485     2485              
  Lines       71386    71335      -51     
  Branches     9030     8999      -31     
==========================================
- Hits        48069    48051      -18     
+ Misses      21173    21152      -21     
+ Partials     2144     2132      -12     
Flag Coverage Δ
shared-data 75.93% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
components/src/instrument/InstrumentDiagram.tsx 75.00% <ø> (ø)
...gner/src/components/BatchEditForm/BatchEditMix.tsx 0.00% <ø> (ø)
...c/components/BatchEditForm/BatchEditMoveLiquid.tsx 0.00% <ø> (ø)
...onents/StepEditForm/fields/FlowRateField/index.tsx 0.00% <ø> (ø)
...m/fields/WellSelectionField/WellSelectionModal.tsx 6.25% <ø> (ø)
...gner/src/components/StepEditForm/forms/MixForm.tsx 0.00% <ø> (ø)
...EditForm/forms/MoveLiquidForm/SourceDestFields.tsx 0.00% <ø> (ø)
...ts/modals/CreateFileWizard/ModulesAndOtherTile.tsx 65.07% <ø> (ø)
...onents/modals/CreateFileWizard/PipetteTipsTile.tsx 90.19% <ø> (+3.40%) ⬆️
...onents/modals/CreateFileWizard/PipetteTypeTile.tsx 88.23% <ø> (+2.52%) ⬆️
... and 19 more

... and 2 files with indirect coverage changes

@jerader jerader changed the title feat(protocol-designer): migrate to using pipette v2 schema feat(protocol-designer, step-generation, shared-data): migrate to using pipette v2 schema Mar 21, 2024
@jerader jerader marked this pull request as ready for review March 21, 2024 19:19
@jerader jerader requested review from a team as code owners March 21, 2024 19:19
@jerader jerader requested a review from a team March 21, 2024 19:19
@jerader jerader requested a review from a team as a code owner March 21, 2024 19:19
@jerader jerader requested review from koji and a team and removed request for a team March 21, 2024 19:19
@jerader jerader requested a review from shlokamin March 25, 2024 13:16
@sanni-t
Copy link
Member

sanni-t commented Mar 25, 2024

The absence of min & max values just seems to be an oversight and we should add them into the v2 definitions in a follow-up. Let me know if you need any help adding them.

screen.getByText('Choose tips for Flex 1-Channel 50 μL')
screen.getByText('mock EquipmentOption')
screen.getByText('Choose tips for Flex 1-Channel 1000 μL')
screen.getAllByText('mock EquipmentOption')
Copy link
Contributor

@koji koji Mar 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to use AllByText instead of getByText?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah with the change in pipette, more equipment options (tiprack options) rendered! had to change it a bit since filtered tips aren't included in the pipette's default tips array right now.

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

@jerader jerader merged commit f583aea into edge Mar 26, 2024
54 of 57 checks passed
@jerader jerader deleted the pd_migrate-to-getPipetteSpecsV2 branch March 26, 2024 16:14
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants