Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components, app): update Chip component for unification #14708

Merged
merged 15 commits into from
Mar 29, 2024
Merged

feat(components, app): update Chip component for unification #14708

merged 15 commits into from
Mar 29, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Mar 20, 2024 •
edited
Loading

Overview

update Chip component for unification.
https://github.com/Opentrons/opentrons/assets/474225/0def2528-15b6-4425-971c-82303fcba5fe

a few tests are commented out because of jsdom's limitations (media-query). I will keep investigating this issue.

close AUTH-214

Test Plan

  • make teardown-js && make setup-js
  • make -C components dev

Changelog

  • move Chip from app to components
  • update Chip component, test, and storybook
  • update all Chip import statements

Review requests

Risk assessment

@koji koji added the components Affects the `components` project label Mar 23, 2024
@koji koji requested review from ncdiehl11, jerader and a team March 28, 2024 17:23
@koji koji marked this pull request as ready for review March 28, 2024 17:28
@koji koji requested a review from a team as a code owner March 28, 2024 17:28
@koji koji removed the request for review from a team March 28, 2024 17:28
jerader
jerader reviewed Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! i left a few comments

@koji koji requested a review from jerader March 29, 2024 14:41
jerader
jerader approved these changes Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@koji
Copy link
Contributor Author

koji commented Mar 29, 2024

@ncdiehl11, could you take a look, when you are available?

@koji koji mentioned this pull request Mar 29, 2024
Merged
ncdiehl11
ncdiehl11 approved these changes Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I can now use the unified Chip from components in my RTP PR.

@koji koji merged commit 0128834 into edge Mar 29, 2024
46 checks passed
@koji koji deleted the feat_chip-component-unification branch April 17, 2024 19:02
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
@koji @Carlos-fernandez
feat(components, app): update Chip component for unification (#14708)
dee3ff9 
* feat(components, app): update Chip component for unification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerader jerader jerader approved these changes

@ncdiehl11 ncdiehl11 ncdiehl11 approved these changes

Assignees
No one assigned
Labels
components Affects the `components` project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koji @ncdiehl11 @jerader