fix(app): Align software keyboard with latest design #14700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t design First change component name close AUTH-133
koji
requested review from
ncdiehl11 and
jerader
and removed request for
a team
jerader
reviewed
Mar 28, 2024
| @@ -0,0 +1,71 @@ | |||
| /* stylelint-disable */ | |||
|
|
|||
| /* Alphanumeric Keyboard has 3 layouts | |||
jerader
reviewed
Mar 28, 2024
|
|
||
| .hg-layout-numbers .hg-row .hg-button { | ||
| height: 44.75px; | ||
| width: 330px !important; |
There was a problem hiding this comment.
what does !important mean?
There was a problem hiding this comment.
to override style. https://developer.mozilla.org/en-US/docs/Web/CSS/important
Generally, using important isn't good and I hate to use it since that makes CSS debug complicated.
I will keep an eye on this to solve important.
jerader
approved these changes
Mar 28, 2024
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
* fix(app): Align software keyboard with latest design
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
design
https://www.figma.com/file/OIdG64Q5cgvEw82ish5Eee/Design-System%3A-Flex?type=design&node-id=7832-138835&mode=design&t=faWySShsSt9MZhan-0
For Numerical Keyboard, I'm still waiting for the design team's update.
close AUTH-133
Test Plan
make -C components devChangelog
Review requests
Risk assessment
low