Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make analyses-snapshot-test PR titles usable as commit titles #14699

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

SyntaxColoring
Copy link
Contributor

Overview

Something in our GitHub config changed recently where, when you click the green merge button on a PR like #14586, it autocompletes the commit message like this:

Evaluate Analyses Snapshot Update edge ([PR number])

We want it to autocomplete like this instead:

fix(app-testing): snapshot failure capture ([PR number])

Test Plan

None needed.

Changelog

  • Change the titles of PRs created by the analyses-snapshot-test.yaml workflow, because they're used to autocomplete the squash commit message.

Review requests

None in particular.

Risk assessment

Low.

@SyntaxColoring SyntaxColoring requested a review from a team as a code owner March 20, 2024 15:11
@SyntaxColoring SyntaxColoring requested a review from y3rsh March 20, 2024 15:11
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thanks! This was actually a change we made to make squash-merge outputs default to PR title, because

  • This was actually always true for PRs with more than one commit
  • But PRs with just one commit (as you noticed) would use the first line of that commit

So we would get a lot of merges that had bad titles. This way, as long as the PR title is ok, the commit will default to that.

This change looks good!

@SyntaxColoring SyntaxColoring merged commit edba100 into edge Mar 20, 2024
10 checks passed
@SyntaxColoring SyntaxColoring deleted the snapshot_pr_titles branch March 20, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants