Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): Border radius final feedback #14695

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Mar 19, 2024

Closes EXEC-338

Overview

Mel has already approved these changes, but they need to make it into the codebase. These are the final BR changes! See EXEC-332 for most of the discussion if you're interested.

Test Plan

  • If interested, verify changes via the discussion in the ticket posted in the Overview.

Risk assessment

low

@mjhuff mjhuff requested review from a team March 19, 2024 19:54
@mjhuff mjhuff requested a review from a team as a code owner March 19, 2024 19:54
@mjhuff mjhuff requested review from shlokamin and removed request for a team and shlokamin March 19, 2024 19:54
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🦖

@mjhuff mjhuff merged commit 456b090 into edge Mar 19, 2024
26 checks passed
@mjhuff mjhuff deleted the border-radius-final-feedback branch March 19, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants