fix(app): fix font size in parameters screen odd #14693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the design team requested us to update the font size of value in parameters screen. close AUTH-218
koji
requested review from
b-cooper
and removed request for
a team and
b-cooper
jerader
reviewed
Mar 19, 2024
| @@ -116,6 +116,8 @@ interface ProtocolSetupStepProps { | |||
| description?: string | |||
| // optional removal of the icon | |||
| hasIcon?: boolean | |||
| // optional enlarge the font size | |||
| hasLargeFont?: boolean | |||
There was a problem hiding this comment.
do we know if this is the only other font size? maybe instead of a boolean, we could call it "fontSize" and then default it to p.
There was a problem hiding this comment.
Actually not sure... , but yeah at this moment what you suggested is better than passing boolean prop.
I will update this. Thanks!
jerader
approved these changes
Mar 19, 2024
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
* fix(app): fix font size in parameters screen odd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
the design team requested us to update the font size of value in parameters screen. (22px -> 28px)
close AUTH-218
related thread
Test Plan
Changelog
Review requests
If there is more efficient way to fix this except re-structuring a component, please let me know.
Risk assessment
low