feat(app): add value key to RTP type #14692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koji
approved these changes
Mar 19, 2024
jerader
force-pushed
the
app_add-value-type-rtp
branch
from
37a21e8 to
735988f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #14692 +/- ##
==========================================
- Coverage 67.56% 67.35% -0.21%
==========================================
Files 2521 2485 -36
Lines 72251 71342 -909
Branches 9311 9012 -299
==========================================
- Hits 48815 48053 -762
+ Misses 21240 21146 -94
+ Partials 2196 2143 -53
Flags with carried forward coverage won't be shown. Click here to find out more.
|
koji
reviewed
Mar 19, 2024
| @@ -621,6 +621,7 @@ interface BaseRunTimeParameter { | |||
| variableName: string | |||
| description: string | |||
| type: RunTimeParameterType | |||
| value: unknown | |||
There was a problem hiding this comment.
maybe
Suggested change
| value: unknown | |
| value: string | number | boolean |
There was a problem hiding this comment.
@shlokamin mentioned in standup that the value should be type any or unknown (but unknown is better) since i guess technically, a user could specify anything for their parameters. The value type in the choice object is also unknown for the same reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes AUTH-216
Overview
Add the top level value key to the run time parameters type.
Test Plan
Changelog
Review requests
see test plan
Risk assessment
low