Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): border radius4 feedback #14681

Merged
merged 2 commits into from
Mar 18, 2024
Merged

refactor(app): border radius4 feedback #14681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
015eb66
desktop app lpc offsets fix
mjhuff Mar 18, 2024
223e228
border radius 4 updates
mjhuff Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/src/organisms/DeviceDetailsDeckConfiguration/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ export function DeviceDetailsDeckConfiguration({
<Flex
key={fixture.cutoutId}
backgroundColor={COLORS.grey20}
borderRadius={BORDERS.borderRadius4}
gridGap={SPACING.spacing60}
padding={SPACING.spacing8}
width="100%"
Expand Down
2 changes: 1 addition & 1 deletion app/src/organisms/LabwareDetails/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ export function LabwareDetails(props: LabwareDetailsProps): JSX.Element {
)}
</Link>
</Box>
<Box border={BORDERS.lineBorder}>
<Box border={BORDERS.lineBorder} borderRadius={BORDERS.borderRadius4}>
<Box padding={SPACING.spacing16}>
<WellCount
wellLabel={getWellLabel(definition)}
Expand Down
14 changes: 12 additions & 2 deletions app/src/organisms/LabwarePositionCheck/ResultsSummary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,12 @@ const OffsetTable = (props: OffsetTableProps): JSX.Element => {

return (
<TableRow key={index}>
<TableDatum>
<TableDatum
css={`
border-radius: ${BORDERS.borderRadius4} 0 0
${BORDERS.borderRadius4};
`}
>
<StyledText
as="p"
textTransform={TYPOGRAPHY.textTransformCapitalize}
Expand All @@ -282,7 +287,12 @@ const OffsetTable = (props: OffsetTableProps): JSX.Element => {
<TableDatum>
<StyledText as="p">{labwareDisplayName}</StyledText>
</TableDatum>
<TableDatum>
<TableDatum
css={`
border-radius: 0 ${BORDERS.borderRadius4}
${BORDERS.borderRadius4} 0;
`}
>
{isEqual(vector, IDENTITY_VECTOR) ? (
<StyledText>{t('no_labware_offsets')}</StyledText>
) : (
Expand Down
2 changes: 1 addition & 1 deletion app/src/organisms/RunPreview/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ export const RunPreviewComponent = (
index === jumpedIndex ? '#F5E3FF' : backgroundColor
}
color={COLORS.black90}
borderRadius={BORDERS.borderRadius8}
borderRadius={BORDERS.borderRadius4}
padding={SPACING.spacing8}
css={css`
transition: background-color ${COLOR_FADE_MS}ms ease-out,
Expand Down
Loading