feat(app): add Parameters tab to odd protocolDetails #14657
Conversation
| @@ -256,6 +258,9 @@ const ProtocolSectionContent = ({ | |||
| /> | |||
| ) | |||
| break | |||
| case 'Parameters': | |||
There was a problem hiding this comment.
not sure an easy way to put this behind the ff? 🤔
There was a problem hiding this comment.
the new option in protocolSectionTabOptions should be behind a FF. you can either make a new constant or conditionally spread it in to the list. but as long as you do that you dont need to put stuff in ProtocolSectionContent cuz it wont be possible to select the params tab
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #14657 +/- ##
==========================================
+ Coverage 67.33% 67.34% +0.01%
==========================================
Files 2485 2485
Lines 71386 71416 +30
Branches 9030 9041 +11
==========================================
+ Hits 48069 48098 +29
Misses 21173 21173
- Partials 2144 2145 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jerader
force-pushed
the
app_parameters-protocol-details-tab
branch
from
2a0190b to
a879479
Compare
| range = `${parameter.choices[0].displayName}, ${parameter.choices[1].displayName}` | ||
| } |
There was a problem hiding this comment.
Oh, you are right. we just need to handle 2 choices this can be better than what I did.
jerader
force-pushed
the
app_parameters-protocol-details-tab
branch
from
99121da to
aded36c
Compare
| } | ||
|
|
||
| return runTimeParameters.length > 0 ? ( | ||
| <Table onClick={makeSnack} data-testid="Parameters_table"> |
There was a problem hiding this comment.
I thought this was fine when we talked about this yesterday's meeting.
But now I think this might show the snack bar unexpectedly.
Right now I'm having the issue of ssh to a dev kit and flexs so not 100% sure but I guess this implementation may show the snack bar when scrolling the lists?
If that doesn't happen, this implementation is okay.
There was a problem hiding this comment.
hmm i might merge this in to not block you but i think you're right that this will cause an issue, i'll post in slack about it. Maybe we need it to appear during a long press
closes AUTH-113, AUTH-124, AUTH-115, AUTH-114
Overview
Creates the parameters tab in the ProtocolDetails section of the ODD also modify the empty section component for parameters
Test Plan
go to protocol details on the odd and see that the parameters tab exists. clicking on the tab should display the empty parameters component. Observe the Parameters page and click on it to make sure the snackbar appears.
Changelog
EmptySectionfor parametersParameterscomponent and testParametersas an option in the types to add it as a tabReview requests
see test plan
Risk assessment
low