Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): refactor app dropdownmenu and inputfield for RTP #14655

Merged
merged 15 commits into from
Mar 15, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Mar 13, 2024

closes AUTH-109
closes AUTH-110

Overview

Modify style and functionality of DropdownMenu and InputField in app in preparation for runtime parameters. In future work, we will prepare these components for use in our shared components library.

Test Plan

InputField

ODD

  • Navigate to Settings > Robot Name
  • Add and remove characters, observing active + error states

Desktop

  • navigate to a Flex Device Details page > Overflow menu in top right corner > Robot settings > Advanced > Rename Robot
  • hover and click into input field
  • type over 17 characters to observe active + error states

DropDown

ODD

  • N/A

Desktop

  • navigate to Labware tab in left of App
  • locate Category filter on top left of page
  • hover and click dropdown box and expanded menu items to observe styling and click behavior

Changelog

  • update styling and css pseudoclasses for inputfield and dropdownmenu App components
  • move styling logic away from component rendering the above components to the components themselves for future usability
  • fix click behavior for both above components

Risk assessment

low

ncdiehl11 and others added 9 commits March 13, 2024 15:58
Modify style and functionality of DropdownMenu and InputField in app in preparation for runtime
parameters. In future work, we will prepare these components for use in our shared components
library.
@ncdiehl11 ncdiehl11 marked this pull request as ready for review March 14, 2024 15:01
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner March 14, 2024 15:01
@ncdiehl11 ncdiehl11 requested review from b-cooper, koji and jerader and removed request for a team March 14, 2024 15:01
@ncdiehl11 ncdiehl11 requested review from koji and jerader March 14, 2024 19:04
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! left some small nits that are nonblocking

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments on type.
Overall LGTM.
Thank you for doing the unification!

@ncdiehl11 ncdiehl11 merged commit 30d9548 into edge Mar 15, 2024
37 checks passed
@ncdiehl11 ncdiehl11 deleted the refactor_app-rtp-components branch March 15, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants