Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(app): add protocol run notes feature flag #14645

Merged
merged 1 commit into from
Mar 13, 2024
Merged

feat(app): add protocol run notes feature flag #14645

merged 1 commit into from
Mar 13, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Mar 13, 2024 •
edited by jira bot
Loading

Closes EXEC-294

Overview

Adds the protocol run notes feature flag! Both to the desktop app and the ODD!

Test Plan

  • App: Verify by going to Settings > Feature Flags. Can verify the config update toggle with Redux devtools.
  • ODD: It's at the bottom of the settings page.

Changelog

  • Added the protocol run notes feature flag.

Risk assessment

low

@mjhuff mjhuff requested a review from a team March 13, 2024 12:52
@mjhuff mjhuff requested a review from a team as a code owner March 13, 2024 12:52
@mjhuff mjhuff requested review from b-cooper and removed request for a team and b-cooper March 13, 2024 12:52
@DerekMaggio
Copy link
Contributor

LGTM!

sfoster1
sfoster1 approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yesss

@mjhuff mjhuff merged commit e40613d into edge Mar 13, 2024
26 checks passed
@mjhuff mjhuff deleted the app_add-notes-ff branch March 13, 2024 14:21
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
@mjhuff @Carlos-fernandez
feat(app): add protocol run notes feature flag (#14645)
922ad7b 
Closes EXEC-294
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfoster1 sfoster1 sfoster1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjhuff @DerekMaggio @sfoster1