Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): add runtime parameters feature flag #14643

Merged
merged 4 commits into from
Mar 12, 2024
Merged

feat(app): add runtime parameters feature flag #14643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e9cd608
feat(app): add runtime parameter feature flag
koji Mar 12, 2024
bad9a44
Merge branch 'edge' into feat_app-runtime-parameter-ff
koji Mar 12, 2024
a2b70b3
fix lint issue
koji Mar 12, 2024
8139c68
parameter -> parameters
koji Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/src/assets/localization/en/app_settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"__dev_internal__protocolStats": "Protocol Stats",
"__dev_internal__enableRunTimeParameters": "Enable Run Time Parameters",
"add_folder_button": "Add labware source folder",
"add_ip_button": "Add",
"add_ip_error": "Enter an IP Address or Hostname",
Expand Down
5 changes: 4 additions & 1 deletion app/src/redux/config/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
import type { DevInternalFlag } from './types'

export const DEV_INTERNAL_FLAGS: DevInternalFlag[] = ['protocolStats']
export const DEV_INTERNAL_FLAGS: DevInternalFlag[] = [
'protocolStats',
'enableRunTimeParameters',
]

// action type constants
export const INITIALIZED: 'config:INITIALIZED' = 'config:INITIALIZED'
Expand Down
2 changes: 1 addition & 1 deletion app/src/redux/config/schema-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export type UpdateChannel = 'latest' | 'beta' | 'alpha'

export type DiscoveryCandidates = string[]

export type DevInternalFlag = 'protocolStats'
export type DevInternalFlag = 'protocolStats' | 'enableRunTimeParameters'

export type FeatureFlags = Partial<Record<DevInternalFlag, boolean | undefined>>

Expand Down
Loading