test(protocol-designer): fix e2e tests after vite migration #14635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlokamin
commented
Mar 12, 2024
| if (module === null) { | ||
| if (moduleId === null) { |
There was a problem hiding this comment.
this was a bug that slipped through years ago... module is a special global keyword that webpack injected so we never noticed the bug. vite does not inject it, so we got a null access error
jerader
approved these changes
Mar 12, 2024
| @@ -1,10 +1,10 @@ | |||
| # Opentrons Protocol Designer Beta | |||
There was a problem hiding this comment.
lol thanks for removing this
|
|
||
| ## Overview | ||
|
|
||
| Protocol Designer is a tool for scientists and technicians to create protocols for their [OT-2 personal pipetting robot][ot-2] without having to write any code. It provides visual feedback including liquid tracking and tip tracking to allow users to see exactly what their protocol will do at each step. The protocols are saved to Opentrons JSON Protocol files, which can be uploaded to the Opentrons Desktop App to run on a robot. | ||
|
|
||
| Protocol Designer Beta is optimized for [Chrome][chrome] browser. Other browsers are not fully supported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes Protocol Designer e2e tests from the vite migration. It also removes references to "beta" within PD cuz... it is not in beta.
Closes AUTH-86
Changelog
Review requests
Make sure PD e2e tests are passing
Risk assessment
Low