Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): add info type to Chip component #14631

Merged
merged 10 commits into from
Mar 16, 2024
Merged

fix(app): add info type to Chip component #14631

merged 10 commits into from
Mar 16, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Mar 12, 2024

Overview

close AUTH-132

Chip component is missing info type in edge. This PR adds the info type.
Update Storybook.

Screenshot 2024-03-12 at 10 20 14 AM

[design]
https://www.figma.com/file/1ot18My22DALIcjdLl5LJh/Helix-Design-System?node-id=2771%3A31590&mode=dev

Test Plan

  • the info styling matches the design
  • update Storybook to use selector and remove redundant lines

Changelog

  • update Chip component to add info
  • update Chip component tests
  • update Chip component storybook (use control to check types easily)

Review requests

Risk assessment

low

koji added 4 commits March 11, 2024 16:27
selector for type didn't work because options is placed under control. this pr fixes that issue.
Chip component is missing info type in edge. This PR adds the info type.
@koji koji requested a review from a team March 12, 2024 14:28
@koji koji marked this pull request as ready for review March 12, 2024 14:29
@koji koji requested a review from a team as a code owner March 12, 2024 14:29
@koji koji requested review from ncdiehl11 and removed request for a team March 12, 2024 14:29
@koji koji marked this pull request as draft March 12, 2024 15:30
@koji koji changed the title feat(app): add info type to Chip component fix(app): add info type to Chip component Mar 15, 2024
@koji koji marked this pull request as ready for review March 15, 2024 20:15
@koji koji removed the request for review from ncdiehl11 March 15, 2024 20:15
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@koji koji merged commit 54094a2 into edge Mar 16, 2024
20 checks passed
@koji koji deleted the feat_add-info-to-chip branch March 16, 2024 15:27
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
* fix(app): add info type to Chip component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants