-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app): add info type to Chip component #14631
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selector for type didn't work because options is placed under control. this pr fixes that issue.
Chip component is missing info type in edge. This PR adds the info type.
koji
changed the title
feat(app): add info type to Chip component
fix(app): add info type to Chip component
Mar 15, 2024
jerader
approved these changes
Mar 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
* fix(app): add info type to Chip component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
close AUTH-132
Chip component is missing info type in edge. This PR adds the info type.
Update Storybook.
[design]
https://www.figma.com/file/1ot18My22DALIcjdLl5LJh/Helix-Design-System?node-id=2771%3A31590&mode=dev
Test Plan
Changelog
Review requests
Risk assessment
low