Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app, shared-data): fix null check issue #14619

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Conversation

koji
Copy link
Contributor

@koji koji commented Mar 11, 2024

Overview

fix a couple of null check issues

Test Plan

Changelog

Review requests

Risk assessment

low

fix a couple of null check issues
@koji koji requested review from mjhuff and jerader March 11, 2024 04:37
@koji koji marked this pull request as ready for review March 11, 2024 04:37
@koji koji requested a review from a team as a code owner March 11, 2024 04:37
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.47%. Comparing base (0b0f04c) to head (b358807).
Report is 2 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #14619   +/-   ##
=======================================
  Coverage   67.47%   67.47%           
=======================================
  Files        2484     2484           
  Lines       71317    71316    -1     
  Branches     9086     9085    -1     
=======================================
  Hits        48120    48120           
+ Misses      21041    21040    -1     
  Partials     2156     2156           
Flag Coverage Δ
shared-data 75.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
app/src/resources/runs/useNotifyRunQuery.ts 0.00% <ø> (ø)

__mocks__/electron-store.js Outdated Show resolved Hide resolved
app/src/resources/runs/useNotifyRunQuery.ts Outdated Show resolved Hide resolved
@koji koji requested a review from mjhuff March 11, 2024 15:09
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@koji koji merged commit 21dff79 into edge Mar 11, 2024
47 of 50 checks passed
@koji koji deleted the fix_small-issues-null-check branch March 11, 2024 17:06
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
* fix(app, shared-data): fix null check issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants