Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): remove z safety margin from pipette movement check #14613

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

sanni-t
Copy link
Member

@sanni-t sanni-t commented Mar 8, 2024

Closes RESC-216

Overview

See the escalations ticket for more info.
Now that we use actual nozzle positions in movement conflict check, we shouldn't need to add such a big safety margin (10mm). We will prefer allowing the movement if it's in the realm of 'slight chance of collision'.

Review requests

Added an integration test. Feel free to throw some tests at it that check for collisions when moving to places where a pipette goes very close to a surrounding labware but falls just short of actually touching it.

Question: There is another way we can handle this and it's keeping the safety margin but making it low, like 2mm. Should we do that instead? See risk assessment for reason.

Risk assessment

Medium- low: there is a slight chance- due to equipment manufacturing tolerance that the pipette might touch/collide a deck item.

@sanni-t sanni-t requested a review from a team as a code owner March 8, 2024 19:20
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.57%. Comparing base (be34672) to head (5bee5d3).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           chore_release-7.2.1   #14613   +/-   ##
====================================================
  Coverage                67.57%   67.57%           
====================================================
  Files                     2521     2521           
  Lines                    72237    72237           
  Branches                  9306     9306           
====================================================
  Hits                     48816    48816           
  Misses                   21226    21226           
  Partials                  2195     2195           
Flag Coverage Δ
g-code-testing 92.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...i/src/opentrons/protocol_api/instrument_context.py 89.09% <ø> (ø)

Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks.

I agree with removing the safety margin entirely until we can report these close shaves as nonblocking warnings.

@sanni-t
Copy link
Member Author

sanni-t commented Mar 11, 2024

Makes sense, thanks.

I agree with removing the safety margin entirely until we can report these close shaves as nonblocking warnings.

That's a good point about warnings!

@sanni-t sanni-t merged commit 5090243 into chore_release-7.2.1 Mar 11, 2024
28 checks passed
@sanni-t sanni-t deleted the api-remove_z_safety_margin branch March 11, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants