feat(api): remove z safety margin from pipette movement check #14613
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RESC-216
Overview
See the escalations ticket for more info.
Now that we use actual nozzle positions in movement conflict check, we shouldn't need to add such a big safety margin (10mm). We will prefer allowing the movement if it's in the realm of 'slight chance of collision'.
Review requests
Added an integration test. Feel free to throw some tests at it that check for collisions when moving to places where a pipette goes very close to a surrounding labware but falls just short of actually touching it.
Question: There is another way we can handle this and it's keeping the safety margin but making it low, like 2mm. Should we do that instead? See risk assessment for reason.
Risk assessment
Medium- low: there is a slight chance- due to equipment manufacturing tolerance that the pipette might touch/collide a deck item.