chore(monorepo): remove jest-when from repo #14612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vite migration branch was merged so we don't need jest-when any more. Removing jest will be done in a following pr since it will require some eslint modification.
koji
requested review from
shlokamin,
a team,
brenthagen,
b-cooper,
smb2268,
mjhuff,
jerader and
ncdiehl11
and removed request for
a team,
shlokamin and
brenthagen
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
* chore(monorepo): remove jest-when from repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
vite migration branch was merged so we don't need jest-when any more. Removing jest will be done in a following pr since it will require some eslint modification.
Test Plan
the following commands work as expect
Changelog
Review requests
Risk assessment
low