fix(api): simulate not logging drop_tip with no args #14606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It works 🎉 |
y3rsh
pushed a commit
that referenced
this pull request
Mar 18, 2024
Fixes [RESC-214](https://opentrons.atlassian.net/browse/RESC-214) - [x] Add simulate test that runs a protocol using `drop_tip` with no args - Add publisher.publish_context context manager when calling drop tip with no args - Add above test case to `test_simulate.py` - It seems that the simulate drop tip functionality could benefit from more robust test coverage. Should make sure that we validate all branches inside of drop_tip. But is this PR the place to do it? Very low. Just added a message and a test [RESC-214]: https://opentrons.atlassian.net/browse/RESC-214?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes RESC-214
Test Plan
drop_tipwith no argsChangelog
test_simulate.pyReview requests
Risk assessment
Very low. Just added a message and a test