chore(app-shell-odd): update electron builder config #14600
Conversation
update electron version info in build config file
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #14600 +/- ##
==========================================
- Coverage 67.57% 67.48% -0.10%
==========================================
Files 2521 2493 -28
Lines 72237 71363 -874
Branches 9306 9096 -210
==========================================
- Hits 48816 48159 -657
+ Misses 21226 21053 -173
+ Partials 2195 2151 -44
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
|
||
| module.exports = { | ||
| appId: 'com.opentrons.odd', | ||
| electronVersion: '23.3.13', | ||
| electronVersion: app.getVersion(), |
There was a problem hiding this comment.
i dont think this is quite right: this will get the version of the app, not electron: https://www.electronjs.org/docs/latest/api/app#appgetversion
i think we want to import our package.json directly:
import pkg from './package.json'
module.exports = {
...
electronVersion: JSON.stringify(pkg.devDependencies.electron),
}
koji
added
the
DO NOT MERGE
sfoster1
added
DO NOT MERGE
|
Corresponding openembedded branch: Opentrons/oe-core#137 |
update electron version info in build config file
There was a problem hiding this comment.
Along with this would we also want to dynamically define electron version in /app-shell/Makefile ? Not sure off the top of my head if that is easy to do in a reliable way.
https://github.com/Opentrons/opentrons/blob/release/app-shell/Makefile#L62
|
With this build https://github.com/Opentrons/oe-core/actions/runs/8238878130 of the oe-core PR and with putting all the built in solibs in, the app doesn't haeve a crash and all its processes are running but is still not displaying |
We used to show mainWindow on the ready-to-show event. For some reason that's just not happening anymore, but everything underneath is actually working fine. Instead, we can show when we get the first dispatch from the app side. This may lead to us spending more time on the pre-app splash and less tim on the spinner.
|
Latest commit alters init behavior. Build with it is here https://github.com/Opentrons/oe-core/actions/runs/8332543203 That openembedded PR will definitely be needed because it also now adds a command line flag that tells chrome to allow all-origin requests for devtools websockets. |
I'm just noting this and uhhhhhhhhhhh what |
OK, had some time to think about this. I think that we should, but maybe in a follow up pr, and honestly I think the most reliable thing to do is use I think we do not want to do this for the ODD. There, we just accept that the version might be different than the desktop. |
sfoster1
removed
the
DO NOT MERGE
Branch for OE changes to support Opentrons/opentrons#14600 Adds a new command line flag to enable remote devtool access on electron 27 and switches out some libraries.
Update the ODD to use electron 27. slightly changes the app's initialization flow in ODD; we now `show()` after the first dispatch from the app side, since `ready-to-show` isn't firing.
Overview
Update electron in builder config file.
Test Plan
Changelog
Review requests
Risk assessment
low