test(shared-data): add pressFit pickUpTipConfigurations validation test #14587
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I started working towards RSS-496 and as I was updating the definitions to use
configsByTipCount
, I realized that that schema was more prone to human errors and was too verbose. Even though the current schema looks a bit redundant with three properties keyed by tip count, having a property written as:as opposed to
is much more readable, easy to peruse at a quick glance and less prone to human errors because you can spot an anomaly in the pattern right away.
Now the present and easily readable schema still has the problem of tip count keys being missed or out of sync. So this PR adds a test that scans all pipette definitions to verify that each definition has identical keys for
speedByTipCount
,distanceByTipCount
¤tByTipCount
.Test Plan
Checked that removing a key from any definition raises error in the added test.
Review requests
Any opposition to not changing the schema?
Risk assessment
None. Just a test