fix(app, app-shell, app-shell-odd): Fix host context for notifications #14548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the host context provider to a couple missing react nice modal components. Because react nice modal exists on a layer outside of the scope of the host context intentionally, we need to provide it manually when it is needed.
There are a few spots (slideout cards) that utilize the notification service but don't have a host object associated with them. In these spots, we pass a host object manually via a host override parameter. Host override was not passed to the notification service, which means that slideout cards did not properly show available robots.
Because OT-2s won't support MQTT for the 7.2 release, mixpanel will report a lot of false positive port block events unless we filter out OT-2s. Let's only send report data for the Flex for now.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.2.0 #14548 +/- ##
=======================================================
- Coverage 67.74% 67.74% -0.01%
=======================================================
Files 2517 2517
Lines 72085 72090 +5
Branches 9282 9286 +4
=======================================================
+ Hits 48834 48835 +1
- Misses 21033 21035 +2
- Partials 2218 2220 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
koji
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RAUT-1018
Overview
This PR contains a few fixes for a few spots in the app that did not properly pass a host object to the notification utility, therefore causing the app to use polling instead of MQTT.
Also, this updates MQTT analytics reporting - it's necessary to only report Flexes, because currently all OT-2s will report that MQTT is blocked (there's no MQTT on OT-2s). Filtering out false positives for the 7.2 release would be nice!
Test Plan
Changelog
Risk assessment
low