Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(robot-server): Delete plot_session.py #14544

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

SyntaxColoring
Copy link
Contributor

Overview

robot-server has a plot_session.py script to generate state machine diagrams of the OT-2's calibration sessions. It hasn't been maintained since August 2020 and it's currently not runnable. We don't think it's worth the effort to fix, so let's delete it.

@b-cooper says:

I’m pretty sure I made this back in the day. That code is now winterized, so nuking it is the most responsible thing to do.

Also, delete an empty session.pdf file presumably left over from one of its runs.

Final PDFs for posterity

Before deleting it, I was able to get it sort of runnable. (The calibration_check session remained broken and raised TypeErrors, and the --wildcard-integrated switch remained broken and raised AttributeErrors.) The code is in this PR's commit history. Here are the PDFs that it generated:

Test plan

None needed.

Review requests

Is this a good idea?

Risk assessment

No risk.

@SyntaxColoring SyntaxColoring added the robot server Affects the `robot-server` project label Feb 23, 2024
@SyntaxColoring SyntaxColoring requested review from a team as code owners February 23, 2024 19:53
@SyntaxColoring SyntaxColoring merged commit 65ef97a into edge Feb 29, 2024
17 checks passed
@SyntaxColoring SyntaxColoring deleted the delete_session_plotting branch February 29, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
robot server Affects the `robot-server` project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants