Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app,components): include moved labware in deck config conflict check #14515

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

brenthagen
Copy link
Contributor

Overview

adds a helper to check for moveLabware commands that use a new slot. use the helper in determining compatibility with the existing deck config. this fixes a bug where the app wasn't surfacing a conflict with a moveLabware command moving to a slot occupied by a trash.

closes RAUT-967

Screen Shot 2024-02-16 at 11 07 45 AM Screen Shot 2024-02-16 at 11 07 49 AM Screen Shot 2024-02-16 at 11 07 56 AM

Test Plan

Verified that conflict generated and resolvable via location conflict modal using the protocol in RAUT-967

Changelog

  • Includes moved labware in deck config conflict check

Review requests

check that move labware commands generate conflicts in the new location

Risk assessment

low

adds a helper to check for moveLabware commands that use a new slot. use the helper in determining
compatibility with the existing deck config. this fixes a bug where the app wasn't surfacing a
conflict with a moveLabware command moving to a slot occupied by a trash.

closes RAUT-967
@brenthagen brenthagen requested a review from a team February 16, 2024 16:19
@brenthagen brenthagen requested a review from a team as a code owner February 16, 2024 16:19
@brenthagen brenthagen requested review from ncdiehl11 and removed request for a team February 16, 2024 16:19
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (d94d485) 67.74% compared to head (8790bc8) 67.71%.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.2.0   #14515      +/-   ##
=======================================================
- Coverage                67.74%   67.71%   -0.03%     
=======================================================
  Files                     2517     2517              
  Lines                    72066    72094      +28     
  Branches                  9278     9286       +8     
=======================================================
+ Hits                     48819    48820       +1     
- Misses                   21027    21054      +27     
  Partials                  2220     2220              
Flag Coverage Δ
app 64.54% <0.00%> (ø)
components 48.29% <3.57%> (-0.62%) ⬇️
labware-library 41.11% <ø> (ø)
protocol-designer 37.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
app/src/resources/deck_configuration/hooks.ts 69.56% <0.00%> (ø)
...rdware-sim/ProtocolDeck/utils/getLabwareInSlots.ts 3.92% <3.57%> (-0.43%) ⬇️

@brenthagen brenthagen requested review from jbleon95 and removed request for ncdiehl11 February 16, 2024 18:11
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me!

@brenthagen brenthagen merged commit 78c85fc into chore_release-7.2.0 Feb 21, 2024
55 of 56 checks passed
@brenthagen brenthagen deleted the app_move-labware-deck-conflict branch February 21, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants