test(robot-server): Add persistence snapshot test for v7.1.1 #14508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxColoring
force-pushed
the
7_1_1_snapshot_test
branch
from
830072f to
5dba80f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.2.0 #14508 +/- ##
====================================================
Coverage 67.76% 67.76%
====================================================
Files 2517 2517
Lines 72058 72058
Branches 9276 9276
====================================================
Hits 48832 48832
Misses 21008 21008
Partials 2218 2218
Flags with carried forward coverage won't be shown. Click here to find out more. |
SyntaxColoring
added
the
robot-svcs
sfoster1
approved these changes
Feb 16, 2024
SyntaxColoring
commented
Feb 20, 2024
Comment on lines
+39
to
+40
| black_opts := --extend-exclude tests/integration/persistence_snapshots/ | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This adds robot-server integration tests for backwards compatibility with v7.1.1 data. This closes RSS-371.
The snapshot data comes from our ABR robots. I've taken a few runs from each robot and combined them into a single Frankenstein snapshot. I also had to massage the data somewhat to correct RSS-469.
Here is the raw ABR robot data (after correcting RSS-469), and here are the scripts I used to create a single snapshot out of it.
Also, configure Git to leave line endings alone for files in the snapshots. At least one of the protocols added here happens to have Windows CRLFs, and it seems like a good idea to keep them.
Review requests
None in particular.
Note that CI is currently failing because of RSS-471, which I'm fixing in #14509.
Risk assessment
No risk.