Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): pronoun agreement typo in unused item modal #14505

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

ecormany
Copy link
Contributor

Overview

these staging area slots…it -> them

Test Plan

Seems no unit test for this string.

Review requests

We could turn this into a broader style/copy pass on this modal or we could just merge the needed typo fix.

Risk assessment

nil

@ecormany ecormany requested review from a team and jerader February 15, 2024 20:50
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (678d5c1) 67.78% compared to head (7757b17) 67.78%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #14505   +/-   ##
=======================================
  Coverage   67.78%   67.78%           
=======================================
  Files        2517     2517           
  Lines       72043    72043           
  Branches     9274     9274           
=======================================
  Hits        48837    48837           
  Misses      20991    20991           
  Partials     2215     2215           
Flag Coverage Δ
protocol-designer 37.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ecormany ecormany merged commit 818292c into edge Feb 15, 2024
23 checks passed
@ecormany ecormany deleted the pd-unused-staging-typo branch October 16, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants