chore: default all py versions to robot-stack #14496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to have different default projects (which happen, it turns out, in the deploy environment) for sdists and wheels and stuff because sdists only existed for flex dev and we hadn't released it yet. Now we have, and we should always be using our robot-stack project unless ot_project is set to something else. Keep the other defaults around but make them ir (for internal release) instead of ot3. This should hopefully prevent the pypi uploads from posting internal-release sdists.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.2.0 #14496 +/- ##
=======================================================
+ Coverage 67.77% 67.79% +0.02%
=======================================================
Files 2517 2517
Lines 72009 72060 +51
Branches 9274 9274
=======================================================
+ Hits 48801 48851 +50
- Misses 20993 20994 +1
Partials 2215 2215
Flags with carried forward coverage won't be shown. Click here to find out more. |
TamarZanzouri
pushed a commit
that referenced
this pull request
Feb 16, 2024
We used to have different default projects (which happen, it turns out, in the deploy environment) for sdists and wheels and stuff because sdists only existed for flex dev and we hadn't released it yet. Now we have, and we should always be using our robot-stack project unless ot_project is set to something else. Keep the other defaults around but make them ir (for internal release) instead of ot3. This should hopefully prevent the pypi uploads from posting internal-release sdists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to have different default projects (which happen, it turns out, in the deploy environment) for sdists and wheels and stuff because sdists only existed for flex dev and we hadn't released it yet. Now we have, and we should always be using our robot-stack project unless ot_project is set to something else.
Keep the other defaults around but make them ir (for internal release) instead of ot3.
This should hopefully prevent the pypi uploads from posting internal-release sdists.
Should fix this: https://github.com/Opentrons/opentrons/actions/runs/7902877476/job/21569838106