Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): firmware update in progress modal graphic #14484

Merged
merged 6 commits into from
Mar 15, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Feb 13, 2024

closes RQA-2343 and EXEC-329

Overview

Replaces in progress bar in subsystem firmware updates with a spinner per designs.

Jamey update - we also display a green check mark if there is no update (not per designs, but per Sue)

Screen.Recording.2024-03-14.at.2.45.25.PM.mov

Test Plan

Two methods:

  1. Initiate subsystem firmware update and observe. You can do so using this app build and/or this flex build. You'll probably have to downgrade the robot to an early 7.2.0 alpha first to trigger a firmware update. Remember to physically remove the pipette/gripper BEFORE updating the robot to the test build.
  2. Change the currentStepIndex for currentStep in L221 to 2. Launch the attach flows for an instrument.

Risk assessment

low

Replaces in progress bar in subsystem firmware updates with a spinner per designs.
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.55%. Comparing base (0cd75c1) to head (7329245).
Report is 2 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #14484      +/-   ##
==========================================
+ Coverage   67.34%   67.55%   +0.20%     
==========================================
  Files        2485     2493       +8     
  Lines       71417    71342      -75     
  Branches     9042     9030      -12     
==========================================
+ Hits        48099    48197      +98     
+ Misses      21173    20983     -190     
- Partials     2145     2162      +17     
Flag Coverage Δ
g-code-testing 92.43% <ø> (ø)
hardware 55.68% <ø> (ø)
hardware-testing ∅ <ø> (∅)
shared-data 75.94% <ø> (ø)
system-server 96.04% <ø> (ø)
update-server 50.56% <ø> (ø)
usb-bridge 76.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
app/src/organisms/FirmwareUpdateModal/index.tsx 86.48% <100.00%> (-1.02%) ⬇️

... and 215 files with indirect coverage changes

@ncdiehl11 ncdiehl11 marked this pull request as ready for review February 13, 2024 15:41
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner February 13, 2024 15:41
@ncdiehl11 ncdiehl11 requested review from jerader and removed request for a team February 13, 2024 15:41
@ncdiehl11 ncdiehl11 changed the title fi(app): firmware update in progress modal graphic fix(app): firmware update in progress modal graphic Feb 13, 2024
@ncdiehl11 ncdiehl11 requested a review from mjhuff February 15, 2024 16:53
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per slack convo with Sue, let's show a green checkmark if no firmware update is required, otherwise show the spinner

@mjhuff mjhuff marked this pull request as draft March 14, 2024 18:04
@mjhuff mjhuff changed the base branch from chore_release-7.2.0 to edge March 14, 2024 19:06
@mjhuff mjhuff marked this pull request as ready for review March 14, 2024 20:10
@mjhuff mjhuff requested review from koji and a team March 14, 2024 20:11
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thank you for fixing this, @nickcrider and @mjhuff !

@mjhuff mjhuff merged commit 1096a6a into edge Mar 15, 2024
88 checks passed
@mjhuff mjhuff deleted the fix_app-firmwareupdate-in-progress-modal branch March 15, 2024 00:25
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants