fix: ensure that pipenv is installed. #14469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current "out-of-the-box" dev experience fails in the following way - `make setup` first invokes - `make setup-js` before it runs `make setup-py` - setup-js invokes a sub-make for the app shell which requires pipenv already setup to build the python protocol analysis sandbox. This is fine if you've already run things before and have pipenv installed locally but it means the standard experience following the dev guides fails. This pulls out the minimal python setup as a dependency of both the setup-py and setup-js build targets
strangemonad
commented
Feb 11, 2024
| # Both the python and JS setup targets depend on a minimal python setup so they can create | ||
| # virtual envs using pipenv. | ||
| .PHONY: setup-py-toolchain | ||
| setup-py-toolchain: |
There was a problem hiding this comment.
open to any naming suggestions here.
sfoster1
approved these changes
Feb 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #14469 +/- ##
==========================================
- Coverage 67.79% 67.72% -0.07%
==========================================
Files 2518 1628 -890
Lines 72017 54953 -17064
Branches 9244 4147 -5097
==========================================
- Hits 48823 37219 -11604
+ Misses 20990 17043 -3947
+ Partials 2204 691 -1513
Flags with carried forward coverage won't be shown. Click here to find out more. |
andySigler
pushed a commit
that referenced
this pull request
Feb 15, 2024
The current "out-of-the-box" dev experience fails in the following way - `make setup` first invokes - `make setup-js` before it runs `make setup-py` - setup-js invokes a sub-make for the app shell which requires pipenv already setup to build the python protocol analysis sandbox. This is fine if you've already run things before and have pipenv installed locally but it means the standard experience following the dev guides fails. This pulls out the minimal python setup as a dependency of both the setup-py and setup-js build targets
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
The current "out-of-the-box" dev experience fails in the following way - `make setup` first invokes - `make setup-js` before it runs `make setup-py` - setup-js invokes a sub-make for the app shell which requires pipenv already setup to build the python protocol analysis sandbox. This is fine if you've already run things before and have pipenv installed locally but it means the standard experience following the dev guides fails. This pulls out the minimal python setup as a dependency of both the setup-py and setup-js build targets
Carlos-fernandez
pushed a commit
that referenced
this pull request
Jun 3, 2024
The current "out-of-the-box" dev experience fails in the following way - `make setup` first invokes - `make setup-js` before it runs `make setup-py` - setup-js invokes a sub-make for the app shell which requires pipenv already setup to build the python protocol analysis sandbox. This is fine if you've already run things before and have pipenv installed locally but it means the standard experience following the dev guides fails. This pulls out the minimal python setup as a dependency of both the setup-py and setup-js build targets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The current "out-of-the-box" dev experience fails in the following way
make setupfirst invokesmake setup-jsbefore it runsmake setup-pyThis is fine if you've already run things before and have pipenv installed locally but it means the standard experience following the dev guides fails.
This pulls out the minimal python setup as a dependency of both the setup-py and setup-js build targets
Test Plan
Manually tested from a clean repo and then re-ran setup in a repo that was already setup.
Changelog
Risk assessment
n/a