fix(app): Fix improper transitioning run status in protocol runs #14459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ropriately Instead of checking the refetchInterval property to see if a notification refetch should occur, we should check if staleTime is infinity. This accurately captures the refetchHTTP behavior that we actually want.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.2.0 #14459 +/- ##
=======================================================
+ Coverage 67.70% 67.78% +0.08%
=======================================================
Files 1628 2519 +891
Lines 54904 72004 +17100
Branches 4147 9256 +5109
=======================================================
+ Hits 37172 48810 +11638
- Misses 17042 20991 +3949
- Partials 690 2203 +1513
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sfoster1
requested changes
Feb 8, 2024
robot-server/robot_server/service/notifications/publishers/runs_publisher.py
Outdated
Show resolved
Hide resolved
robot-server/robot_server/service/notifications/publishers/runs_publisher.py
Outdated
Show resolved
Hide resolved
sfoster1
requested changes
Feb 9, 2024
robot-server/robot_server/service/notifications/publishers/runs_publisher.py
Outdated
Show resolved
Hide resolved
TamarZanzouri
pushed a commit
that referenced
this pull request
Feb 16, 2024
) Closes RQA-2291, RQA-2307, RQA-2306, RQA-2304 * fix(app): fix non polling notify hooks not always refetching data appropriately Instead of checking the refetchInterval property to see if a notification refetch should occur, we should check if staleTime is infinity. This accurately captures the refetchHTTP behavior that we actually want. * fix(app): fix infinite cancelling run state when run status is idle->stop-requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RQA-2291, RQA-2307, RQA-2306, RQA-2304
Overview
This PR fixes a bug on the app side in which the incorrect React Query property was used. In order to prevent any refetches, staleTime is the correct choice. Certain useRunQuery and useAllRunQuery hooks that were not updating properly now update as expected. Also, the removed
RUN_STATUS_STOP_REQUESTEDis added back to useRunStatus(), since its removal was causing bug RQA-2306.The python side changes are all sanity check changes - nothing functionally new here. A new push is added to the remove method, since we want to push on every new CRUD. I don't know if this was causing bugs, but it should be fixed.
Test Plan
Changelog
Risk assessment
low