Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hardware): add CAN messages to control the Hepa/UV filter. #14452

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

vegano1
Copy link
Contributor

@vegano1 vegano1 commented Feb 8, 2024

Overview

We need to control the Hepa/UV filter from the Flex for testing and eventual system integration, this PR adds the CAN message definition to configure and control the Hepa fan and UV light on the device. This PR coincides with Opentrons/ot3-firmware#753 PR.

Closes: RET-1422 RET-1423

Test Plan

  • Test Plan in firmware pr.

Changelog

  • Added CAN messages to set/get the hepa fan state/pwm
  • Added CAN messages to set/get the hepa light state/timeout

Review requests

  • Does the API make sense?

Risk assessment

low, unreleased

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@vegano1 vegano1 merged commit 43ad3db into edge Feb 8, 2024
19 checks passed
@vegano1 vegano1 deleted the RET-1422_add_hepa_control_can_msg branch February 8, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants