chore: update typescript to 5.3.3 #14407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates typescript to latest. updates eslint to latest. fixes some typescript errors, ignores some typescript errors. suppresses new eslint errors.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## edge #14407 +/- ##
==========================================
- Coverage 68.25% 68.21% -0.05%
==========================================
Files 1629 2520 +891
Lines 54889 71912 +17023
Branches 4125 9188 +5063
==========================================
+ Hits 37465 49053 +11588
- Misses 16735 20686 +3951
- Partials 689 2173 +1484
Flags with carried forward coverage won't be shown. Click here to find out more.
|
brenthagen
commented
Feb 1, 2024
| @@ -5,6 +5,7 @@ | |||
| **/build/** | |||
| **/venv/** | |||
| .opentrons_config | |||
| **/tsconfig*.json | |||
There was a problem hiding this comment.
typescript-eslint/parser seems unable to parse tsconfig json files, so we're ignoring them
brenthagen
commented
Feb 1, 2024
| 'standard-with-typescript', | ||
| 'plugin:react/recommended', | ||
| 'prettier', | ||
| 'plugin:json/recommended', |
There was a problem hiding this comment.
turns out, without extending these rules we weren't actually linting json files in edge. so now we're actually linting json
There was a problem hiding this comment.
downside: linting json via typescript-eslint/parser takes about an extra minute to run
There was a problem hiding this comment.
twas a breaking change in a previous version of https://github.com/azeemba/eslint-plugin-json?tab=readme-ov-file#eslint-plugin-json
brenthagen
requested review from
TamarZanzouri
and removed request for
a team and
TamarZanzouri
shlokamin
approved these changes
Feb 1, 2024
jerader
approved these changes
Feb 1, 2024
| @@ -13,7 +13,7 @@ const page: Reducer<Page, any> = handleActions( | |||
| }, | |||
| 'file-splash' | |||
| ) | |||
| // @ts-expect-error(sa, 2021-6-21): TS thinks this will only return false, even though TOGGLE_NEW_PROTOCOL_MODAL might yield true | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
updates typescript to latest. updates eslint to latest. fixes some typescript errors, ignores some typescript errors. suppresses new eslint errors. enables json linting, fixes json linting errors.
Test Plan
CI passing, builds building
Changelog
Review requests
check local builds
Risk assessment
medium-high