fix(g-code-testing): relock for new r-s deps #14391
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #14391 +/- ##
=======================================
Coverage 68.24% 68.24%
=======================================
Files 2512 2512
Lines 71877 71877
Branches 9175 9175
=======================================
Hits 49055 49055
Misses 20656 20656
Partials 2166 2166
Flags with carried forward coverage won't be shown. Click here to find out more. |
SyntaxColoring
requested changes
Jan 30, 2024
There was a problem hiding this comment.
I think I fixed this accidentally in #14280. If we leave edge as-is, it should be good now, with paho-mqtt in there. If we merge this, it'll clobber the notify-server deletions.
|
Oh, great call, thanks for catching that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to get the paho dep in there