Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): no js source only types shared-data/.npmignore #14372

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

y3rsh
Copy link
Member

@y3rsh y3rsh commented Jan 29, 2024

Overview

The wiring up in webpack when js/ is included does not work and tries to point at the included *.ts files which I am guessing is why this was ignored in shared-data/.npmignore in the first place.

0.1.2-alpha.1

Import trace for requested module:
./node_modules/@opentrons/shared-data/js/constants.ts
./node_modules/@opentrons/shared-data/js/index.ts

./node_modules/@opentrons/shared-data/js/errors.ts
Module parse failed: Unexpected token (3:7)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
| import errorDefinitions from '../errors/definitions/1/errors.json'
|
> export type ErrorCodes = keyof typeof errorDefinitions.codes
| export type ErrorCategories = keyof typeof errorDefinitions.categories
|

Test Plan

  • Tag an alpha on this branch and see if it works.

Changelog

  • ignore source js/ in shared-data/.npmignore
  • do not ignore lib/js/ in shared-data/.npmignore

Risk assessment

None to any functional code. CI only change to what webpack uses and what gets packed and pushed to npm.

@y3rsh y3rsh requested a review from a team as a code owner January 29, 2024 17:46
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (88de889) 68.10% compared to head (1624a04) 68.06%.
Report is 1 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #14372      +/-   ##
==========================================
- Coverage   68.10%   68.06%   -0.05%     
==========================================
  Files        2503     1621     -882     
  Lines       71614    54710   -16904     
  Branches     9113     4087    -5026     
==========================================
- Hits        48775    37238   -11537     
+ Misses      20711    16817    -3894     
+ Partials     2128      655    -1473     
Flag Coverage Δ
app 38.71% <ø> (-26.90%) ⬇️
components 48.85% <ø> (ø)
protocol-designer 35.30% <ø> (ø)
shared-data 75.25% <ø> (ø)
step-generation 86.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 883 files with indirect coverage changes

@y3rsh
Copy link
Member Author

y3rsh commented Jan 29, 2024

This fixed it!
@b-cooper approve merge and tag non alpha 😊

Copy link
Contributor

@b-cooper b-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎏

@b-cooper b-cooper merged commit 50471ae into edge Jan 29, 2024
67 checks passed
ncdiehl11 pushed a commit that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants