fix(shared-data): load pick up current properly #14350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While we properly handled _most_ kinds of pipette config, there's one we didn't: pick up current. It gets special treatment now because we can properly set different currents for different numbers of tips, rather than being a value. So, we need to mark it as a setting that needs to be iterated over a dictionary in its leaf value rather than directly set. This also fixes an issue that caused the OT-2 to not boot when loading a pipette configuration that had a pick up current customization, since this code is called when loading a pipette. It may be closing the barn after the horse escapes, but to prevent similar issues preventing boot, I also tossed in a catch all except that logs a loud message but won't prevent starting the server. Closes RESC-187
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## edge #14350 +/- ##
==========================================
+ Coverage 68.05% 68.08% +0.03%
==========================================
Files 2508 2508
Lines 71594 71645 +51
Branches 9106 9126 +20
==========================================
+ Hits 48721 48780 +59
- Misses 20757 20761 +4
+ Partials 2116 2104 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
vegano1
approved these changes
Jan 25, 2024
ncdiehl11
pushed a commit
that referenced
this pull request
Feb 1, 2024
While we properly handled _most_ kinds of pipette config, there's one we didn't: pick up current. It gets special treatment now because we can properly set different currents for different numbers of tips, rather than being a value. So, we need to mark it as a setting that needs to be iterated over a dictionary in its leaf value rather than directly set. This also fixes an issue that caused the OT-2 to not boot when loading a pipette configuration that had a pick up current customization, since this code is called when loading a pipette. It may be closing the barn after the horse escapes, but to prevent similar issues preventing boot, I also tossed in a catch all except that logs a loud message but won't prevent starting the server. Closes RESC-187
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we properly handled most kinds of pipette config, there's one we didn't: pick up current. It gets special treatment now because we can properly set different currents for different numbers of tips, rather than being a value. So, we need to mark it as a setting that needs to be iterated over a dictionary in its leaf value rather than directly set.
This also fixes an issue that caused the OT-2 to not boot when loading a pipette configuration that had a pick up current customization, since this code is called when loading a pipette.
It may be closing the barn after the horse escapes, but to prevent similar issues preventing boot, I also tossed in a catch all except that logs a loud message but won't prevent starting the server.
Testing
Closes RESC-187