fix(api): fix left mount being disengaged when moving to maintenance position #14341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahiuchingau
force-pushed
the
fix_home-z-l-if-disengaged-prior
branch
from
00a1be5 to
e2b7eb8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #14341 +/- ##
=======================================
Coverage 68.05% 68.05%
=======================================
Files 2508 2508
Lines 71595 71595
Branches 9106 9106
=======================================
Hits 48722 48722
Misses 20757 20757
Partials 2116 2116
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ahiuchingau
force-pushed
the
fix_home-z-l-if-disengaged-prior
branch
from
b06dde0 to
1ffcda6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We now disengage the left z axis if a 96-channel pipette is attached but idle. This means that during gripper calibration, the left Z axis will not have a valid motor position (disengaged at the home position). We won't be able to move nor access the position of the Z_L until we first home it. This shouldn't take long because it should already be at its home position.